Small bug when not using photochemistry#365
Merged
dustinswales merged 10 commits intoApr 29, 2026
Merged
Conversation
… into feature/mpas_in_ufs
… into feature/mpas_in_ufs
… into feature/mpas_in_ufs
dustinswales
requested review from
Qingfu-Liu,
grantfirl and
rhaesung
as code owners
32 tasks
rhaesung
approved these changes
Mar 24, 2026
Qingfu-Liu
approved these changes
Mar 24, 2026
grantfirl
approved these changes
Mar 27, 2026
… into feature/mpas_in_ufs
|
|
||
| !> - Update ozone concentration. | ||
| if (ntoz > 0) then | ||
| if (rjday < ozphys%time(1)) rjday = rjday + 365. |
There was a problem hiding this comment.
I'm not familiar with the context here but isn't this off by a day for leap years?
… into feature/mpas_in_ufs
|
Testing completed successfully for ufs-community/ufs-weather-model#3156. This PR can be merged. |
climbfuji
approved these changes
Apr 29, 2026
Collaborator
Author
|
@grantfirl @rhaesung Can one of you hit the button? |
Collaborator
|
Thanks @dustinswales |
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes:
GFS_phys_time_vary has a dependency that the ozone and h2o photolysis are always active.
Tests Conducted:
Discovered when running the MPAS UWM RTs, which don't yet have photochemistry initialized.
Dependencies:
Add any links to parent PRs (e.g. SCM and/or UFS PRs) or submodules (e.g. rte-rrtmgp). For example: